Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gc dry run issue #19208

Merged
merged 1 commit into from Aug 21, 2023
Merged

fix gc dry run issue #19208

merged 1 commit into from Aug 21, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Aug 17, 2023

In the dry run mode, the accessories should be considered when try to simulate delete the subject manifest.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #19208 (44291d5) into main (c7e2529) will decrease coverage by 0.01%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19208      +/-   ##
==========================================
- Coverage   67.39%   67.38%   -0.01%     
==========================================
  Files         993      993              
  Lines      108888   108896       +8     
  Branches     2751     2751              
==========================================
+ Hits        73382    73383       +1     
- Misses      31561    31571      +10     
+ Partials     3945     3942       -3     
Flag Coverage Δ
unittests 67.38% <5.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/jobservice/job/impl/gc/garbage_collection.go 45.43% <5.88%> (-0.52%) ⬇️

... and 7 files with indirect coverage changes

In the dry run mode, the accessories should be considered when try to simulate delete the subject manifest.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 927e7f9 into goharbor:main Aug 21, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants