Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Remove job status track information from redis after stop the job in the queue #19306

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Sep 5, 2023

After stop in the queue:
Remove key in {harbor_job_service_namespace}:job_track:inprogress
Remove {harbor_job_service_namespace}:job_stats:<job_id>
fixes #19211

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…the queue

  After stop in the queue:
  Remove key in {harbor_job_service_namespace}:job_track:inprogress
  Remove {harbor_job_service_namespace}:job_stats:<job_id>
  fixes goharbor#19211

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner September 5, 2023 02:19
@stonezdj stonezdj changed the title (cherry-pick) Remove job status track information from redis after stop job in queu (cherry-pick) Remove job status track information from redis after stop job in queue Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #19306 (3e8614f) into release-2.7.0 (a324b2d) will decrease coverage by 0.01%.
Report is 1 commits behind head on release-2.7.0.
The diff coverage is 52.38%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19306      +/-   ##
=================================================
- Coverage          66.40%   66.39%   -0.01%     
=================================================
  Files               1012     1012              
  Lines             108692   108713      +21     
  Branches            2678     2678              
=================================================
+ Hits               72172    72185      +13     
- Misses             32555    32564       +9     
+ Partials            3965     3964       -1     
Flag Coverage Δ
unittests 66.39% <52.38%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...oute-reuse-strategy/harbor-route-reuse-strategy.ts 28.26% <ø> (ø)
src/pkg/jobmonitor/redis.go 17.58% <52.38%> (+17.58%) ⬆️

... and 10 files with indirect coverage changes

@stonezdj stonezdj changed the title (cherry-pick) Remove job status track information from redis after stop job in queue (cherry-pick) Remove job status track information from redis after stop job in the queue Sep 5, 2023
@stonezdj stonezdj changed the title (cherry-pick) Remove job status track information from redis after stop job in the queue (cherry-pick) Remove job status track information from redis after stop the job in the queue Sep 5, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) September 5, 2023 04:08
@stonezdj stonezdj merged commit 4d1695c into goharbor:release-2.7.0 Sep 6, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants