Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick)fix storage.redirect.disable migrate template error release-2.8.0 #19337

Merged

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Sep 11, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19320

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #19337 (a24540b) into release-2.8.0 (206c5b8) will increase coverage by 0.00%.
Report is 1 commits behind head on release-2.8.0.
The diff coverage is 52.38%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.8.0   #19337   +/-   ##
==============================================
  Coverage          70.53%   70.54%           
==============================================
  Files                749      749           
  Lines              93978    93999   +21     
==============================================
+ Hits               66284    66308   +24     
+ Misses             24107    24103    -4     
- Partials            3587     3588    +1     
Flag Coverage Δ
unittests 70.54% <52.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/jobmonitor/redis.go 17.58% <52.38%> (+17.58%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MinerYang MinerYang merged commit 7a43ecc into goharbor:release-2.8.0 Sep 12, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants