Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate resource label #19349

Merged
merged 2 commits into from
Sep 13, 2023
Merged

deprecate resource label #19349

merged 2 commits into from
Sep 13, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Sep 13, 2023

There is no api is using the DAO, remove it from the source code.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

There is no api is using the DAO, remove it from the source code.

Signed-off-by: wang yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #19349 (cef6193) into main (12ce915) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19349      +/-   ##
==========================================
+ Coverage   67.37%   67.46%   +0.08%     
==========================================
  Files         993      988       -5     
  Lines      108915   108689     -226     
  Branches     2752     2752              
==========================================
- Hits        73384    73327      -57     
+ Misses      31585    31416     -169     
  Partials     3946     3946              
Flag Coverage Δ
unittests 67.46% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/common/models/base.go 100.00% <ø> (ø)
src/pkg/label/model/model.go 85.00% <ø> (+7.72%) ⬆️

... and 9 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/deprecation Harbor Deprecation MUST need to be in release notes label Sep 13, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit ed370a4 into goharbor:main Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation Harbor Deprecation MUST need to be in release notes target/2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants