Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default processor for unknwon type config #19372

Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19175

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #19372 (653c916) into main (50e466b) will increase coverage by 0.00%.
The diff coverage is 15.38%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19372   +/-   ##
=======================================
  Coverage   67.45%   67.46%           
=======================================
  Files         988      988           
  Lines      108688   108688           
  Branches     2752     2752           
=======================================
+ Hits        73316    73321    +5     
+ Misses      31431    31420   -11     
- Partials     3941     3947    +6     
Flag Coverage Δ
unittests 67.46% <15.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/controller/artifact/processor/default.go 54.76% <8.33%> (-16.67%) ⬇️
src/server/middleware/subject/subject.go 49.31% <100.00%> (ø)

... and 10 files with indirect coverage changes

@zyyw
Copy link
Contributor

zyyw commented Sep 19, 2023

We may also need to add this to this PR:

w.Header().Set("OCI-Subject", subjectArt.Digest)
->
w.Header().Set("OCI-Subject", mf.Subject.Digest.String())

@MinerYang
Copy link
Contributor Author

We may also need to add this to this PR:

* https://github.com/goharbor/harbor/pull/19367/files#diff-e600b4a9acca6ebd3c99f257f5f44aa7a387e5220ccd87eda5fe84f1c400fa04
w.Header().Set("OCI-Subject", subjectArt.Digest)
->
w.Header().Set("OCI-Subject", mf.Subject.Digest.String())

True. thx

@MinerYang MinerYang force-pushed the update_default_processor_unknwon_type branch from 8381eda to 47ea46b Compare September 19, 2023 02:19
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the update_default_processor_unknwon_type branch from 47ea46b to 9c52e75 Compare September 21, 2023 05:21
update OCI-Subject header

Signed-off-by: yminer <yminer@vmware.com>

update default processor & add ut for artifact icon

update ut coverage
@MinerYang MinerYang force-pushed the update_default_processor_unknwon_type branch from 9c52e75 to 653c916 Compare September 21, 2023 06:31
@MinerYang MinerYang merged commit 6fd4a2b into goharbor:main Sep 21, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance test issue -- References setup
5 participants