Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): update french translations #19418

Merged
merged 1 commit into from Oct 10, 2023
Merged

Conversation

Nhqml
Copy link
Contributor

@Nhqml Nhqml commented Oct 5, 2023

Comprehensive Summary of your change

Add and fix French translations

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@Nhqml Nhqml requested a review from a team as a code owner October 5, 2023 21:55
@Vad1mo Vad1mo added the release-note/update Update or Fix label Oct 8, 2023
@Vad1mo Vad1mo enabled auto-merge (squash) October 8, 2023 11:56
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #19418 (319690b) into main (d0322df) will decrease coverage by 22.59%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19418       +/-   ##
===========================================
- Coverage   67.45%   44.86%   -22.59%     
===========================================
  Files         988      244      -744     
  Lines      108732    13416    -95316     
  Branches     2752     2752               
===========================================
- Hits        73340     6019    -67321     
+ Misses      31446     7093    -24353     
+ Partials     3946      304     -3642     
Flag Coverage Δ
unittests 44.86% <ø> (-22.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kenji Gaillac <kenji@gaillac.eu>
@Vad1mo Vad1mo merged commit 27e70cd into goharbor:main Oct 10, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants