Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch to list the job id in the job queue to avoid crash redis #19444

Merged
merged 1 commit into from Oct 18, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Oct 16, 2023

fixes: #19436

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner October 16, 2023 02:38
@stonezdj stonezdj added the release-note/update Update or Fix label Oct 16, 2023
@stonezdj stonezdj assigned wy65701436 and chlins and unassigned Vad1mo, zyyw and OrlinVasilev Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #19444 (035d788) into main (84a85fb) will decrease coverage by 25.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19444       +/-   ##
===========================================
- Coverage   70.62%   44.81%   -25.81%     
===========================================
  Files         744      244      -500     
  Lines       95316    13416    -81900     
  Branches        0     2752     +2752     
===========================================
- Hits        67319     6013    -61306     
+ Misses      24356     7097    -17259     
+ Partials     3641      306     -3335     
Flag Coverage Δ
unittests 44.81% <ø> (-25.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 988 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23oct11_page_lrange branch 2 times, most recently from 843552f to f5d8662 Compare October 16, 2023 05:50
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) October 18, 2023 08:48
  fixes: goharbor#19436

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj merged commit d030ab2 into goharbor:main Oct 18, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to stop the huge number replication job queues
6 participants