feat: volc cr adapter #19456
Merged
feat: volc cr adapter #19456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
f7961b2
to
0f1a44c
Compare
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
0f1a44c
to
990174e
Compare
zycupup
force-pushed
the
feat-volcCR-adapter
branch
2 times, most recently
from
7df95ba
to
a1688a3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #19456 +/- ##
===========================================
+ Coverage 45.30% 67.45% +22.15%
===========================================
Files 244 996 +752
Lines 13333 109763 +96430
Branches 2720 2720
===========================================
+ Hits 6040 74042 +68002
- Misses 6993 31740 +24747
- Partials 300 3981 +3681
Flags with carried forward coverage won't be shown. Click here to find out more.
|
stonezdj
reviewed
Nov 15, 2023
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
a1688a3
to
77aeca8
Compare
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
77aeca8
to
19c21d7
Compare
stonezdj
approved these changes
Nov 22, 2023
stonezdj
force-pushed
the
feat-volcCR-adapter
branch
from
19c21d7
to
9b3cff9
Compare
YangJiao0817
added
release-note/new-feature
|
@zycupup could you please resolve the conflict? |
sure, i will. And I will fix the UTTEST error together |
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
9b3cff9
to
0d99776
Compare
YangJiao0817
force-pushed
the
feat-volcCR-adapter
branch
from
0d99776
to
7303552
Compare
Signed-off-by: zhuyuchen.1 <zhuyuchen.1@bytedance.com>
zycupup
force-pushed
the
feat-volcCR-adapter
branch
from
7303552
to
4723e13
Compare
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
feat: support volcEngine replication Signed-off-by: zhuyuchen.1 <zhuyuchen.1@bytedance.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Add new adapter for volcEngine registry:(https://www.volcengine.com/)
support both pull-based and push-based
Issue being fixed
Fixes #(issue)
Please indicate you've done the following:
Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.