Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC accessory API test case #19462

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Oct 18, 2023

Fix #19273

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Oct 18, 2023
@YangJiao0817 YangJiao0817 self-assigned this Oct 18, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner October 18, 2023 02:50
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) October 18, 2023 02:50
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #19462 (1b5a472) into main (13f4fca) will decrease coverage by 22.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19462       +/-   ##
===========================================
- Coverage   67.46%   44.93%   -22.54%     
===========================================
  Files         988      244      -744     
  Lines      108743    13416    -95327     
  Branches     2752     2752               
===========================================
- Hits        73360     6028    -67332     
+ Misses      31430     7083    -24347     
+ Partials     3953      305     -3648     
Flag Coverage Δ
unittests 44.93% <ø> (-22.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

@YangJiao0817 YangJiao0817 force-pushed the add-gc-accessory-api-testcase branch 3 times, most recently from 8579704 to 0473f7f Compare October 18, 2023 06:45
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fix goharbor#19273

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 merged commit 322dce5 into goharbor:main Oct 20, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GC accessory API test case
5 participants