Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to validate username when update user profile #19552

Merged
merged 1 commit into from Nov 8, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 7, 2023

fixes #19528

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #19552 (5a6b598) into main (35a605e) will increase coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19552   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         988      988           
  Lines      108777   108780    +3     
  Branches     2737     2737           
=======================================
+ Hits        73437    73448   +11     
+ Misses      31374    31371    -3     
+ Partials     3966     3961    -5     
Flag Coverage Δ
unittests 67.51% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/v2.0/handler/user.go 19.55% <80.00%> (-0.90%) ⬇️

... and 7 files with indirect coverage changes

  fixes goharbor#19528

Signed-off-by: stonezdj <daojunz@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit c921425 into goharbor:main Nov 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users with long usernames cannot be modified
5 participants