perf: optimize the performance of accessory query #19557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
added
the
release-note/enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #19557 +/- ##
==========================================
- Coverage 45.38% 45.23% -0.16%
==========================================
Files 244 244
Lines 13323 13323
Branches 2719 2719
==========================================
- Hits 6046 6026 -20
- Misses 6974 6995 +21
+ Partials 303 302 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
stonezdj
approved these changes
Nov 10, 2023
zyyw
approved these changes
Nov 14, 2023
1. Add db index for subject_artifact_id in table artifact_accessory. 2. Optimize the SQL of excluding the accessory for artifact count. Signed-off-by: chlins <chenyuzh@vmware.com>
zyyw
reviewed
Nov 14, 2023
| @@ -97,7 +97,6 @@ require ( | |||
| github.com/davecgh/go-spew v1.1.1 // indirect | |||
| github.com/denverdino/aliyungo v0.0.0-20191227032621-df38c6fa730c // indirect | |||
| github.com/dgryski/go-rendezvous v0.0.0-20200823014737-9f7001d12a5f // indirect | |||
| github.com/distribution/reference v0.5.0 // indirect | |||
There was a problem hiding this comment.
Why would this be removed? Is it not used indeed?
There was a problem hiding this comment.
We should not need this package, automatically removed after runninggo mod tidy.
chlins
force-pushed
the
perf/query-accessory
branch
from
f80e6be
to
9446ce3
Compare
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Nov 22, 2023
1. Add db index for subject_artifact_id in table artifact_accessory. 2. Optimize the SQL of excluding the accessory for artifact count. Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: wang yan <wangyan@vmware.com>
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
1. Add db index for subject_artifact_id in table artifact_accessory. 2. Optimize the SQL of excluding the accessory for artifact count. Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: