Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Allow POST method to request service/token in readonly mode #19562

Merged
merged 1 commit into from Nov 13, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 10, 2023

fixes #18243

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#18243

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner November 10, 2023 06:10
@stonezdj stonezdj added the release-note/update Update or Fix label Nov 10, 2023
@stonezdj stonezdj assigned zyyw and chlins and unassigned Vad1mo, OrlinVasilev and chlins Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #19562 (a8342d3) into release-2.8.0 (206c5b8) will decrease coverage by 3.18%.
Report is 2 commits behind head on release-2.8.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19562      +/-   ##
=================================================
- Coverage          70.53%   67.35%   -3.18%     
=================================================
  Files                749      984     +235     
  Lines              93978   107090   +13112     
  Branches               0     2671    +2671     
=================================================
+ Hits               66284    72127    +5843     
- Misses             24107    31082    +6975     
- Partials            3587     3881     +294     
Flag Coverage Δ
unittests 67.35% <ø> (-3.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/middlewares/middlewares.go 0.00% <ø> (ø)

... and 241 files with indirect coverage changes

@stonezdj stonezdj enabled auto-merge (squash) November 10, 2023 06:14
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 10286c7 into goharbor:release-2.8.0 Nov 13, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants