Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Allow POST method to request service/token in readonly mode #19563

Merged
merged 1 commit into from Nov 13, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 10, 2023

fixes #18243

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

  fixes goharbor#18243

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner November 10, 2023 06:12
@stonezdj stonezdj added the release-note/update Update or Fix label Nov 10, 2023
@stonezdj stonezdj changed the title Allow POST method to request service/token in readonly mode [cherry-pick] Allow POST method to request service/token in readonly mode Nov 10, 2023
@stonezdj stonezdj enabled auto-merge (squash) November 10, 2023 06:14
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #19563 (63fc27f) into release-2.9.0 (6f85d59) will increase coverage by 0.03%.
Report is 21 commits behind head on release-2.9.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19563      +/-   ##
=================================================
+ Coverage          67.38%   67.41%   +0.03%     
=================================================
  Files                993      993              
  Lines             108921   108932      +11     
  Branches            2752     2752              
=================================================
+ Hits               73396    73440      +44     
+ Misses             31580    31541      -39     
- Partials            3945     3951       +6     
Flag Coverage Δ
unittests 67.41% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/middlewares/middlewares.go 0.00% <ø> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit d85ebd7 into goharbor:release-2.9.0 Nov 13, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants