Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty result when no scanner configured #19577

Merged
merged 1 commit into from Nov 17, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 14, 2023

fixes #19534

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner November 14, 2023 11:45
@stonezdj stonezdj added the release-note/update Update or Fix label Nov 14, 2023
@stonezdj stonezdj force-pushed the 23nov14_return_empty_no_scanner branch from 8b413ee to 87c3b71 Compare November 14, 2023 11:46
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #19577 (3df9a28) into main (08cb080) will decrease coverage by 22.24%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19577       +/-   ##
===========================================
- Coverage   67.55%   45.32%   -22.24%     
===========================================
  Files         990      244      -746     
  Lines      109060    13323    -95737     
  Branches     2719     2719               
===========================================
- Hits        73672     6038    -67634     
+ Misses      31424     6984    -24440     
+ Partials     3964      301     -3663     
Flag Coverage Δ
unittests 45.32% <ø> (-22.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 749 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23nov14_return_empty_no_scanner branch from 87c3b71 to 2db6cac Compare November 15, 2023 06:26
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  fixes goharbor#19534

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj enabled auto-merge (squash) November 17, 2023 06:52
@stonezdj stonezdj force-pushed the 23nov14_return_empty_no_scanner branch from 2db6cac to 3df9a28 Compare November 17, 2023 06:53
@stonezdj stonezdj merged commit 307a312 into goharbor:main Nov 17, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
fixes goharbor#19534

Signed-off-by: stonezdj <daojunz@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The summary API and vul API report an 500 error when no scannner is installed
6 participants