Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up golang-runtime from 1.19.3 to 1.21.4; upgrade MOCKERY_VERSION; upgrade golangci-lint; fix mock issue #19608

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Nov 23, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #19608 (045ea77) into release-2.7.0 (ad94f93) will decrease coverage by 3.17%.
The diff coverage is 12.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19608      +/-   ##
=================================================
- Coverage          69.55%   66.39%   -3.17%     
=================================================
  Files                767     1012     +245     
  Lines              95315   108728   +13413     
  Branches               0     2678    +2678     
=================================================
+ Hits               66301    72188    +5887     
- Misses             25337    32574    +7237     
- Partials            3677     3966     +289     
Flag Coverage Δ
unittests 66.39% <12.00%> (-3.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/retry/retry.go 100.00% <100.00%> (ø)
src/pkg/permission/evaluator/rbac/casbin_match.go 89.13% <100.00%> (ø)
src/jobservice/period/mock_scheduler.go 45.94% <25.00%> (-4.06%) ⬇️
src/jobservice/mgt/mock_manager.go 6.14% <0.00%> (-0.73%) ⬇️

... and 248 files with indirect coverage changes

@zyyw zyyw force-pushed the release-270-bump-golang-1.21.4 branch 5 times, most recently from 98477d9 to 191b6ff Compare November 24, 2023 01:21
…lint version to v1.51.2; upgrade MOCKERY_VERSION to v2.22.1; fix mock issue

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the release-270-bump-golang-1.21.4 branch from 191b6ff to 045ea77 Compare November 24, 2023 02:08
@zyyw zyyw changed the title feat: bump up golang-runtime from 1.19.3 to 1.21.4 feat: bump up golang-runtime from 1.19.3 to 1.21.4; upgrade MOCKERY_VERSION; upgrade golangci-lint; fix mock issue Nov 24, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit d0a5032 into goharbor:release-2.7.0 Nov 24, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants