Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade dependency library version and run "go mod vendor" #19613

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Nov 24, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #19613 (aed08d6) into release-2.7.0 (d0a5032) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.7.0   #19613   +/-   ##
==============================================
  Coverage          66.39%   66.39%           
==============================================
  Files               1012     1012           
  Lines             108728   108728           
  Branches            2678     2678           
==============================================
+ Hits               72187    72188    +1     
  Misses             32573    32573           
+ Partials            3968     3967    -1     
Flag Coverage Δ
unittests 66.39% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/trace/trace.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@zyyw zyyw force-pushed the release-270-dependency-upgrade branch from 1ed70ca to 5b7e6cf Compare November 24, 2023 03:49
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the release-270-dependency-upgrade branch from 5b7e6cf to aed08d6 Compare November 24, 2023 07:16
@zyyw zyyw enabled auto-merge (squash) November 24, 2023 08:01
@zyyw zyyw disabled auto-merge November 24, 2023 08:01
@zyyw zyyw changed the title fix: upgrade dependency library version fix: upgrade dependency library version and run "go mod vendor" Nov 24, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit c07f5ce into goharbor:release-2.7.0 Nov 24, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants