Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the test script for the project permissions #19623

Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 27, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner November 27, 2023 08:54
@AllForNothing AllForNothing added the release-note/infra Infra related changes e.g. release, test, ship etc... label Nov 27, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #19623 (09f2ff6) into main (bf251ef) will decrease coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19623      +/-   ##
==========================================
- Coverage   45.38%   45.26%   -0.12%     
==========================================
  Files         244      244              
  Lines       13325    13325              
  Branches     2719     2719              
==========================================
- Hits         6047     6032      -15     
- Misses       6977     6991      +14     
- Partials      301      302       +1     
Flag Coverage Δ
unittests 45.26% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@AllForNothing AllForNothing enabled auto-merge (squash) November 27, 2023 09:04
@AllForNothing AllForNothing force-pushed the project-permission-scripts branch 2 times, most recently from 2a3fc72 to 273c5a1 Compare November 27, 2023 10:53
@AllForNothing AllForNothing enabled auto-merge (squash) November 27, 2023 10:53
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit f26b9f5 into goharbor:main Nov 28, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants