Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix robot account access issue #19627

Merged
merged 3 commits into from Nov 27, 2023
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Nov 27, 2023

fixes #19622
Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #19627 (a411c82) into main (e1df9b0) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19627      +/-   ##
==========================================
+ Coverage   67.51%   67.55%   +0.03%     
==========================================
  Files         991      991              
  Lines      109167   109168       +1     
  Branches     2719     2719              
==========================================
+ Hits        73699    73743      +44     
+ Misses      31497    31453      -44     
- Partials     3971     3972       +1     
Flag Coverage Δ
unittests 67.55% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/security/robot/context.go 93.05% <100.00%> (+22.63%) ⬆️

... and 11 files with indirect coverage changes

fixes goharbor#19622
Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 3f72604 into goharbor:main Nov 27, 2023
12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
fixes goharbor#19622
Resolve the 403 issue occurring when a robot account, equipped with both system and project scope, attempts to access project resources.

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication failed with system level robot account
6 participants