Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user API test case #19638

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

YangJiao0817
Copy link
Member

Fix #19280

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #19638 (3794ffe) into main (f26b9f5) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19638      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.03%     
==========================================
  Files         991      991              
  Lines      109168   109168              
  Branches     2719     2719              
==========================================
- Hits        73757    73733      -24     
- Misses      31443    31461      +18     
- Partials     3968     3974       +6     
Flag Coverage Δ
unittests 67.54% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Fix goharbor#19280

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 7cef421 into goharbor:main Nov 29, 2023
17 of 18 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Fix goharbor#19280

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user API test case
6 participants