Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the style for the robot acccount ui #19663

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Dec 5, 2023

  1. Fixes The placeholder of quota search input is partly covered #19614
  2. Fixes Robot account UI fields overlap #19617

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #19663 (bf0cb65) into main (1cbc901) will increase coverage by 0.01%.
The diff coverage is 30.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19663      +/-   ##
==========================================
+ Coverage   45.31%   45.33%   +0.01%     
==========================================
  Files         244      244              
  Lines       13331    13332       +1     
  Branches     2719     2719              
==========================================
+ Hits         6041     6044       +3     
+ Misses       6988     6986       -2     
  Partials      302      302              
Flag Coverage Δ
unittests 45.33% <30.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...issions-panel/robot-permissions-panel.component.ts 55.93% <30.00%> (-7.87%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. Fixes goharbor#19614
2. Fixes goharbor#19617

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
@AllForNothing AllForNothing merged commit 469b6a4 into goharbor:main Dec 5, 2023
11 of 12 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
1. Fixes goharbor#19614
2. Fixes goharbor#19617

Signed-off-by: AllForNothing <shijun.sun@broadcom.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robot account UI fields overlap The placeholder of quota search input is partly covered
5 participants