Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: increase beego max memory and upload size (#19578) #19670

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Dec 5, 2023

  1. Increase the default beego max memory and upload size from 32GB to 128GB.
  2. Support customize the two beego configs from env.

(cherry picked from commit 553c85e)

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Increase the default beego max memory and upload size from 32GB to
   128GB.
2. Support customize the two beego configs from env.

Signed-off-by: chlins <chenyuzh@vmware.com>
Co-authored-by: Wang Yan <wangyan@vmware.com>

(cherry picked from commit 553c85e)
Signed-off-by: stonezdj <daojunz@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #19670 (916244f) into release-2.8.0 (10286c7) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19670      +/-   ##
=================================================
+ Coverage          67.34%   67.37%   +0.03%     
=================================================
  Files                984      984              
  Lines             107090   107094       +4     
  Branches            2671     2671              
=================================================
+ Hits               72122    72158      +36     
+ Misses             31085    31053      -32     
  Partials            3883     3883              
Flag Coverage Δ
unittests 67.37% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/config/systemconfig.go 50.35% <0.00%> (-1.48%) ⬇️

... and 7 files with indirect coverage changes

@wy65701436 wy65701436 merged commit c097e4c into goharbor:release-2.8.0 Dec 6, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants