Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Add quota permissions to robot account #19800

Merged

Conversation

YangJiao0817
Copy link
Member

Fix #19792

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#19792

Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 5, 2024 06:45
@YangJiao0817 YangJiao0817 changed the title Add quota permissions to robot account [cherry-pick]Add quota permissions to robot account Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f19f84) 67.55% compared to head (631747a) 67.53%.
Report is 3 commits behind head on release-2.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #19800      +/-   ##
==================================================
- Coverage           67.55%   67.53%   -0.02%     
==================================================
  Files                 991      991              
  Lines              109175   109175              
  Branches             2719     2719              
==================================================
- Hits                73748    73735      -13     
- Misses              31458    31467       +9     
- Partials             3969     3973       +4     
Flag Coverage Δ
unittests 67.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ide-nav/system-robot-accounts/system-robot-util.ts 64.06% <ø> (ø)

... and 5 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) January 5, 2024 06:59
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit f62f04b into goharbor:release-2.10.0 Jan 8, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants