Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] add repository read permission to limitedGuest #19816

Merged
merged 1 commit into from Jan 15, 2024

Conversation

tpoxa
Copy link
Contributor

@tpoxa tpoxa commented Jan 8, 2024

Issue being fixed

Fixes #19709

Realted to PR #19757

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Maksym Trofimenko <maksym@container-registry.com>
@tpoxa tpoxa requested a review from a team as a code owner January 8, 2024 18:38
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f19f84) 67.55% compared to head (f1d7545) 70.64%.
Report is 6 commits behind head on release-2.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.10.0   #19816      +/-   ##
==================================================
+ Coverage           67.55%   70.64%   +3.09%     
==================================================
  Files                 991      747     -244     
  Lines              109175    95843   -13332     
  Branches             2719        0    -2719     
==================================================
- Hits                73748    67708    -6040     
+ Misses              31458    24467    -6991     
+ Partials             3969     3668     -301     
Flag Coverage Δ
unittests 70.64% <ø> (+3.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/rbac/project/rbac_role.go 70.00% <ø> (ø)

... and 246 files with indirect coverage changes

@Vad1mo Vad1mo added the release-note/update Update or Fix label Jan 9, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 9, 2024 10:21
@Vad1mo Vad1mo merged commit cf41c69 into goharbor:release-2.10.0 Jan 15, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants