Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]fix label select bugs (#19850) #19862

Merged
merged 1 commit into from Jan 19, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: shengqiw <shengqiw@vmware.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (236ece8) 67.53% compared to head (ba2bc83) 67.53%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-2.10.0   #19862   +/-   ##
===============================================
  Coverage           67.53%   67.53%           
===============================================
  Files                 991      991           
  Lines              109180   109181    +1     
  Branches             2719     2719           
===============================================
+ Hits                73734    73739    +5     
+ Misses              31478    31473    -5     
- Partials             3968     3969    +1     
Flag Coverage Δ
unittests 67.53% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/create-edit-rule/create-edit-rule.component.ts 35.71% <50.00%> (+0.18%) ⬆️

... and 6 files with indirect coverage changes

@YangJiao0817 YangJiao0817 changed the title fix label select bugs (#19850) [cherry-pick]fix label select bugs (#19850) Jan 19, 2024
@YangJiao0817 YangJiao0817 requested review from MinerYang and removed request for stonezdj January 19, 2024 06:13
@zyyw
Copy link
Contributor

zyyw commented Jan 19, 2024

@YangJiao0817 Please label with a release version of this PR.

@YangJiao0817 YangJiao0817 merged commit f5b8647 into goharbor:release-2.10.0 Jan 19, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants