Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v6 port for nginx and portal config #19868

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19865

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Jan 22, 2024
@MinerYang MinerYang requested a review from a team as a code owner January 22, 2024 05:19
@MinerYang MinerYang changed the title add v6 port for nginx ad portal config add v6 port for nginx and portal config Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d88a320) 67.45% compared to head (1e44043) 45.36%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19868       +/-   ##
===========================================
- Coverage   67.45%   45.36%   -22.09%     
===========================================
  Files         996      244      -752     
  Lines      109773    13333    -96440     
  Branches     2720     2720               
===========================================
- Hits        74042     6048    -67994     
+ Misses      31747     6983    -24764     
+ Partials     3984      302     -3682     
Flag Coverage Δ
unittests 45.36% <ø> (-22.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 756 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang enabled auto-merge (squash) January 24, 2024 08:49
@MinerYang MinerYang merged commit 522f96b into goharbor:main Jan 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 connection to Harbor Web GUI not working properly
7 participants