Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update replication rule filter label xpath #19895

Merged
merged 1 commit into from Jan 24, 2024
Merged

Update replication rule filter label xpath #19895

merged 1 commit into from Jan 24, 2024

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Jan 23, 2024
@YangJiao0817 YangJiao0817 self-assigned this Jan 23, 2024
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 23, 2024 08:47
chlins
chlins approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817
Update replication rule filter label xpath
350b134 
Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
@zyyw zyyw merged commit 0db0d21 into goharbor:main Jan 24, 2024
10 checks passed
zyyw pushed a commit to zyyw/harbor that referenced this pull request Jan 24, 2024
@YangJiao0817 @zyyw
Update replication rule filter label xpath (goharbor#19895)
f77d597 
Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
zyyw pushed a commit to zyyw/harbor that referenced this pull request Jan 24, 2024
@YangJiao0817 @zyyw
Update replication rule filter label xpath (goharbor#19895)
410c8b0 
Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
zyyw added a commit that referenced this pull request Jan 25, 2024
@zyyw @YangJiao0817
[Cherry-Pick] Update replication rule filter label xpath (#19895) (#1…
4694d88 
…9904)

Update replication rule filter label xpath (#19895)

Signed-off-by: Yang Jiao <yang.jiao@broadcom.com>
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Co-authored-by: Yang Jiao <72076317+YangJiao0817@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@chlins chlins chlins approved these changes

Assignees

@Vad1mo Vad1mo

@chlins chlins

@MinerYang MinerYang

@YangJiao0817 YangJiao0817

Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YangJiao0817 @zyyw @chlins @Vad1mo @MinerYang