Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move strong_ssl_ciphers to top level in harbor.yml #19914

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jan 26, 2024

fixes #19912

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 26, 2024 10:04
@stonezdj stonezdj changed the title Move strong_ssl_ciphers to top level in harbor.yaml [WIP] Move strong_ssl_ciphers to top level in harbor.yaml Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (a3e1b1e) to head (74c8eb1).
Report is 19 commits behind head on main.

❗ Current head 74c8eb1 differs from pull request most recent head 0b7c699. Consider uploading reports for the commit 0b7c699 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19914      +/-   ##
==========================================
- Coverage   67.45%   67.45%   -0.01%     
==========================================
  Files         996      996              
  Lines      109773   109773              
  Branches     2720     2720              
==========================================
- Hits        74044    74043       -1     
- Misses      31747    31750       +3     
+ Partials     3982     3980       -2     
Flag Coverage Δ
unittests 67.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@stonezdj stonezdj added the release-note/update Update or Fix label Jan 26, 2024
@stonezdj stonezdj changed the title [WIP] Move strong_ssl_ciphers to top level in harbor.yaml Move strong_ssl_ciphers to top level in harbor.yaml Feb 22, 2024
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stonezdj stonezdj force-pushed the 24jan27_fix_ssl_cipher branch 5 times, most recently from 0b0a19d to daf66c2 Compare February 22, 2024 10:40
@stonezdj
Copy link
Contributor Author

stonezdj commented Feb 22, 2024

should we take care of these two parts as well

Updated, just need to migrate the 2.10

@stonezdj stonezdj force-pushed the 24jan27_fix_ssl_cipher branch 2 times, most recently from 2fd0e7e to 45a5c80 Compare February 23, 2024 03:34
@stonezdj stonezdj force-pushed the 24jan27_fix_ssl_cipher branch 2 times, most recently from d111e62 to 8aafe07 Compare February 23, 2024 06:29
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj changed the title Move strong_ssl_ciphers to top level in harbor.yaml Move strong_ssl_ciphers to top level in harbor.yml Feb 23, 2024
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  fixes goharbor#19912

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj merged commit 2b6608f into goharbor:main Feb 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The internal_tls.strong_ssl_ciphers options doesn't work in harbor.yml
5 participants