Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] feat: enable configuration of skip_java_db_update #19997

Merged
merged 1 commit into from Feb 21, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Feb 20, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19759

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a79c5da) 67.42% compared to head (0de12b2) 67.41%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19997      +/-   ##
=================================================
- Coverage          67.42%   67.41%   -0.02%     
=================================================
  Files                993      993              
  Lines             108982   108982              
  Branches            2752     2752              
=================================================
- Hits               73479    73468      -11     
- Misses             31540    31555      +15     
+ Partials            3963     3959       -4     
Flag Coverage Δ
unittests 67.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@zyyw zyyw added the kind/helm-chart-impact The issues that require change in the helm chart. label Feb 20, 2024
@zyyw zyyw merged commit ce85f47 into goharbor:release-2.9.0 Feb 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/helm-chart-impact The issues that require change in the helm chart. release-note/update Update or Fix target/2.9.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants