Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Limit URL to local site #20023

Merged
merged 1 commit into from Feb 26, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Feb 23, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner February 23, 2024 07:50
@stonezdj stonezdj changed the title Limit URL to local site [cherry-pick] Limit URL to local site Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (3356196) to head (ebfc4e8).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #20023      +/-   ##
=================================================
+ Coverage          67.41%   67.43%   +0.01%     
=================================================
  Files                993      993              
  Lines             108982   108990       +8     
  Branches            2752     2752              
=================================================
+ Hits               73470    73493      +23     
+ Misses             31553    31537      -16     
- Partials            3959     3960       +1     
Flag Coverage Δ
unittests 67.43% <22.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/utils/utils.go 78.13% <100.00%> (+0.20%) ⬆️
src/core/controllers/oidc.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@stonezdj stonezdj enabled auto-merge (squash) February 23, 2024 08:06
Signed-off-by: stonezdj <daojunz@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 9115b9f into goharbor:release-2.9.0 Feb 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants