Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos #20106

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: typos #20106

merged 1 commit into from
Mar 11, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Mar 8, 2024 •
edited

Thank you for contributing to Harbor!

Comprehensive Summary of your change

fix typos in make/harbor.yml.tmpl

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@testwill
fix: typos
3859bdb 
Signed-off-by: guangwu <guoguangwu@magic-shield.com>
@testwill testwill requested a review from a team as a code owner March 8, 2024 07:06
MinerYang
MinerYang approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang added the release-note/update Update or Fix label Mar 11, 2024
@MinerYang MinerYang merged commit 6ca30a3 into goharbor:main Mar 11, 2024
12 checks passed
@testwill testwill deleted the patch-1 branch March 11, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@MinerYang MinerYang MinerYang approved these changes

@Vivekgaddigi Vivekgaddigi Vivekgaddigi approved these changes

Assignees

@Vad1mo Vad1mo

@zyyw zyyw

@MinerYang MinerYang

Labels
release-note/update Update or Fix target/2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@testwill @zyyw @MinerYang @Vivekgaddigi @Vad1mo