Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix function names #20159

Merged
merged 2 commits into from
Mar 26, 2024
Merged

chore: fix function names #20159

merged 2 commits into from
Mar 26, 2024

Conversation

majorteach
Copy link
Contributor

@majorteach majorteach commented Mar 23, 2024 •
edited by wy65701436

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@majorteach majorteach requested a review from a team as a code owner March 23, 2024 09:38
wy65701436
wy65701436 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@majorteach @stonezdj
chore: fix function names
19ee5c3 
Signed-off-by: majorteach <csgcgl@126.com>
@stonezdj stonezdj added the release-note/update Update or Fix label Mar 25, 2024
@wy65701436 wy65701436 merged commit fd81e7c into goharbor:main Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonezdj stonezdj stonezdj approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@Vad1mo Vad1mo

@stonezdj stonezdj

@wy65701436 wy65701436

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@majorteach @stonezdj @wy65701436 @Vad1mo