Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] panic due to mark retention task error #20169

Merged
merged 1 commit into from Mar 26, 2024

Conversation

stonezdj
Copy link
Contributor

fixes #20129

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fixes goharbor#20129

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner March 26, 2024 05:31
@stonezdj stonezdj changed the title panic due to mark retention task error [cherry-pick] panic due to mark retention task error Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.27%. Comparing base (b7b8847) to head (f5f8130).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2.10.0   #20169       +/-   ##
===================================================
- Coverage           67.56%   45.27%   -22.30%     
===================================================
  Files                 991      244      -747     
  Lines              109181    13333    -95848     
  Branches             2719     2719               
===================================================
- Hits                73768     6036    -67732     
+ Misses              31449     6996    -24453     
+ Partials             3964      301     -3663     
Flag Coverage Δ
unittests 45.27% <ø> (-22.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 752 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) March 26, 2024 05:39
@stonezdj stonezdj merged commit 17c32f0 into goharbor:release-2.10.0 Mar 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants