Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #20190

Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix: typo #20190

merged 1 commit into from
Apr 1, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Mar 29, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

fix typo in error info

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@testwill testwill requested a review from a team as a code owner March 29, 2024 08:57
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (b7b8847) to head (c7689a4).
Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20190      +/-   ##
==========================================
- Coverage   67.56%   67.43%   -0.13%     
==========================================
  Files         991      997       +6     
  Lines      109181   109883     +702     
  Branches     2719     2724       +5     
==========================================
+ Hits        73768    74101     +333     
- Misses      31449    31793     +344     
- Partials     3964     3989      +25     
Flag Coverage Δ
unittests 67.43% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 511 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: guoguangwu <guoguangwug@gmail.com>
auto-merge was automatically disabled March 30, 2024 14:17

Head branch was pushed to by a user without write access

@zyyw zyyw merged commit b66d14d into goharbor:main Apr 1, 2024
11 of 12 checks passed
@testwill testwill deleted the typo branch April 1, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants