Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Allow empty path in redirect_url #20236

Merged
merged 1 commit into from Apr 8, 2024
Merged

[cherry-pick] Allow empty path in redirect_url #20236

merged 1 commit into from Apr 8, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Apr 8, 2024

fixes #20226

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Allow empty path in redirect_url
d1e35a8 
  fixes goharbor#20226

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj requested a review from a team as a code owner April 8, 2024 02:15
@stonezdj stonezdj requested a review from zyyw April 8, 2024 02:16
@stonezdj stonezdj requested a review from wy65701436 April 8, 2024 02:16
@stonezdj stonezdj assigned wy65701436 and unassigned zyyw, OrlinVasilev and chlins Apr 8, 2024
wy65701436
wy65701436 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 0339b82 into goharbor:release-2.9.0 Apr 8, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@zyyw zyyw zyyw approved these changes

Assignees

@wy65701436 wy65701436

Labels
release-note/update Update or Fix target/2.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stonezdj @wy65701436 @zyyw @OrlinVasilev @chlins