Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scan job request log for enabled_capabilities #20414

Merged
merged 1 commit into from
May 10, 2024

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#20411

2024-05-10T08:31:05Z [DEBUG] [/pkg/scan/job.go:407]: scanRequest:
2024-05-10T08:31:05Z [INFO] [/pkg/scan/job.go:418]: {
  "registry": {
    "url": "http://core:8080",
    "authorization": "[HIDDEN]"
  },
  "artifact": {
    "namespace_id": 1,
    "repository": "library/goharbor/spectral",
    "tag": "test",
    "digest": "sha256:501c46137740b45171a91707f1009817beb3aac21b65a4e2271734d3d86c4940",
    "mime_type": "application/vnd.docker.distribution.manifest.v2+json",
    "size": 321311585
  },
  "enabled_capabilities": [
    {
      "type": "sbom",
      "produces_mime_types": [
        "application/vnd.security.sbom.report+json; version=1.0"
      ],
      "parameters": {
        "sbom_media_types": [
          "application/spdx+json"
        ]
      }
    }
  ]
}

Signed-off-by: yminer <yminer@vmware.com>
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.36%. Comparing base (b7b8847) to head (2a88ba0).
Report is 179 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20414      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113085    +3904     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75050    +1282     
- Misses      31449    33984    +2535     
- Partials     3964     4051      +87     
Flag Coverage Δ
unittests 66.36% <100.00%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/job.go 31.44% <100.00%> (+0.96%) ⬆️

... and 566 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 068ae00 into goharbor:main May 10, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants