Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip scan in-toto sbom artifact #20415

Merged
merged 2 commits into from May 13, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented May 10, 2024

fixes #20337
Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 10, 2024 13:03
@stonezdj stonezdj added the release-note/update Update or Fix label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 66.35%. Comparing base (b7b8847) to head (75e330d).
Report is 181 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20415      +/-   ##
==========================================
- Coverage   67.56%   66.35%   -1.22%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113117    +3936     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75055    +1287     
- Misses      31449    34003    +2554     
- Partials     3964     4059      +95     
Flag Coverage Δ
unittests 66.35% <35.71%> (-1.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/controller.go 61.99% <57.14%> (+0.22%) ⬆️
src/controller/scan/base_controller.go 56.76% <14.28%> (-2.79%) ⬇️
src/controller/scan/checker.go 55.07% <14.28%> (-4.61%) ⬇️

... and 565 files with indirect coverage changes

  fixes goharbor#20337

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 232f9ba into goharbor:main May 13, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got crash in the harbor core on scan CVE and Generate SBOM
5 participants