Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 20407 #20416

Merged
merged 1 commit into from May 13, 2024
Merged

fix issue 20407 #20416

merged 1 commit into from May 13, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 11, 2024

fixes #20407
It needs to specify the insecure option on parsing the reference

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner May 11, 2024 07:30
@wy65701436 wy65701436 assigned chlins and unassigned zyyw and MinerYang May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 66.36%. Comparing base (b7b8847) to head (3535718).
Report is 180 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20416      +/-   ##
==========================================
- Coverage   67.56%   66.36%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113089    +3908     
  Branches     2719     2830     +111     
==========================================
+ Hits        73768    75056    +1288     
- Misses      31449    33981    +2532     
- Partials     3964     4052      +88     
Flag Coverage Δ
unittests 66.36% <22.22%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/rest/v1/models.go 58.16% <ø> (+13.56%) ⬆️
src/pkg/scan/util.go 64.70% <0.00%> (ø)
src/pkg/scan/sbom/sbom.go 65.16% <33.33%> (ø)

... and 566 files with indirect coverage changes

fixes goharbor#20407
It needs to specify the insecure option on parsing the reference

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 65e266f into goharbor:main May 13, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate SBOM error when deployed by HTTP
5 participants