Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-20459 Wrong sbom status displayed in UI #20460

Merged
merged 1 commit into from
May 21, 2024

Conversation

xuelichao
Copy link
Contributor

Fix Wrong sbom status displayed in UI

Issue being fixed

Fixes #20459

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao added the release-note/ignore-for-release Do not include PR or Issue for release notes label May 21, 2024
@xuelichao xuelichao requested a review from a team as a code owner May 21, 2024 03:25
@xuelichao xuelichao self-assigned this May 21, 2024
@xuelichao xuelichao force-pushed the sbom-ui branch 3 times, most recently from 5c1e878 to 83c2093 Compare May 21, 2024 03:49
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.37%. Comparing base (b7b8847) to head (42f73cd).
Report is 193 commits behind head on main.

Current head 42f73cd differs from pull request most recent head 2a7e98e

Please upload reports for the commit 2a7e98e to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20460      +/-   ##
==========================================
- Coverage   67.56%   66.37%   -1.20%     
==========================================
  Files         991     1042      +51     
  Lines      109181   113185    +4004     
  Branches     2719     2840     +121     
==========================================
+ Hits        73768    75121    +1353     
- Misses      31449    33999    +2550     
- Partials     3964     4065     +101     
Flag Coverage Δ
unittests 66.37% <ø> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 568 files with indirect coverage changes

@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from 4e40909 to ee9d5ad Compare May 21, 2024 06:54
Signed-off-by: xuelichao <xuel@vmware.com>
@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from 42f73cd to 2a7e98e Compare May 21, 2024 08:59
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 3875b1a into goharbor:main May 21, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SBOM column having SBOM.COMPLETED, when SBOM generation completed.
5 participants