-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittent broken pipe
issue in log
#4719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes goharbor#4713, by adopting the suggested fix in: go-sql-driver/mysql#529 When creating the DB instance in orm, call `SetConnMaxLifetime()`
ywk253100
approved these changes
Apr 19, 2018
Vad1mo
added a commit
to container-registry/harbor
that referenced
this pull request
Jun 26, 2021
…oharbor#4719 Signed-off-by: Vadim Bauer <vb@container-registry.com>
Closed
Vad1mo
added a commit
to container-registry/harbor
that referenced
this pull request
Jun 26, 2021
…oharbor#4719 Signed-off-by: Vadim Bauer <vb@container-registry.com>
Vad1mo
added a commit
to container-registry/harbor
that referenced
this pull request
Jun 26, 2021
…oharbor#4719 Signed-off-by: Vadim Bauer <vb@container-registry.com>
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Jul 29, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
wy65701436
pushed a commit
to wy65701436/harbor
that referenced
this pull request
Aug 9, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com> Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436
added a commit
that referenced
this pull request
Aug 9, 2021
…4719 (#15211) (#15374) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com> Signed-off-by: Wang Yan <wangyan@vmware.com> Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
yunkunrao
pushed a commit
to yunkunrao/harbor
that referenced
this pull request
Aug 19, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
danielzhanghl
pushed a commit
to nokia/harbor
that referenced
this pull request
Aug 26, 2021
…oharbor#4719 (goharbor#15211) (goharbor#15374) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com> Signed-off-by: Wang Yan <wangyan@vmware.com> Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
heww
pushed a commit
to heww/harbor
that referenced
this pull request
Sep 8, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
heww
pushed a commit
to heww/harbor
that referenced
this pull request
Sep 8, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com>
heww
pushed a commit
to heww/harbor
that referenced
this pull request
Sep 8, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Signed-off-by: He Weiwei <hweiwei@vmware.com>
wy65701436
pushed a commit
that referenced
this pull request
Sep 9, 2021
lindhe
pushed a commit
to lindhe/harbor
that referenced
this pull request
Sep 22, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com> Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Nov 12, 2021
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
prahaladdarkin
pushed a commit
to prahaladdarkin/harbor
that referenced
this pull request
Mar 13, 2022
…oharbor#4719 (goharbor#15211) Signed-off-by: Vadim Bauer <vb@container-registry.com> Co-authored-by: Vadim Bauer <vb@container-registry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #4713, by adopting the suggested fix in:
go-sql-driver/mysql#529
I have verified this on the longevity test environment, we can keep this in master as long as we don't see impact in 1.5 release.