Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent broken pipe issue in log #4719

Merged
merged 1 commit into from
Apr 19, 2018

Conversation

reasonerjt
Copy link

This commit fixes #4713, by adopting the suggested fix in:
go-sql-driver/mysql#529

I have verified this on the longevity test environment, we can keep this in master as long as we don't see impact in 1.5 release.

This commit fixes goharbor#4713, by adopting the suggested fix in:
go-sql-driver/mysql#529
When creating the DB instance in orm, call `SetConnMaxLifetime()`
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 64.49% when pulling 7fa8261 on reasonerjt:fix-db-broken-pipe into 5792829 on vmware:master.

@reasonerjt reasonerjt merged commit f8d5779 into goharbor:master Apr 19, 2018
@reasonerjt reasonerjt deleted the fix-db-broken-pipe branch February 21, 2019 07:34
Vad1mo added a commit to container-registry/harbor that referenced this pull request Jun 26, 2021
@Vad1mo Vad1mo mentioned this pull request Jun 26, 2021
Vad1mo added a commit to container-registry/harbor that referenced this pull request Jun 26, 2021
Vad1mo added a commit to container-registry/harbor that referenced this pull request Jun 26, 2021
wy65701436 pushed a commit that referenced this pull request Jul 23, 2021
…4719 (#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Jul 29, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
wy65701436 pushed a commit to wy65701436/harbor that referenced this pull request Aug 9, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>
wy65701436 added a commit that referenced this pull request Aug 9, 2021
…4719 (#15211) (#15374)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
Co-authored-by: Vadim Bauer <vb@container-registry.com>
yunkunrao pushed a commit to yunkunrao/harbor that referenced this pull request Aug 19, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
danielzhanghl pushed a commit to nokia/harbor that referenced this pull request Aug 26, 2021
…oharbor#4719 (goharbor#15211) (goharbor#15374)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Wang Yan <wangyan@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
Co-authored-by: Vadim Bauer <vb@container-registry.com>
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
heww pushed a commit to heww/harbor that referenced this pull request Sep 8, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: He Weiwei <hweiwei@vmware.com>
wy65701436 pushed a commit that referenced this pull request Sep 9, 2021
…4719 (#15211) (#15559)

Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: He Weiwei <hweiwei@vmware.com>

Co-authored-by: Vadim Bauer <1492007+Vad1mo@users.noreply.github.com>
lindhe pushed a commit to lindhe/harbor that referenced this pull request Sep 22, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: Andreas Lindhé <andreas@lindhe.io>
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Nov 12, 2021
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
prahaladdarkin pushed a commit to prahaladdarkin/harbor that referenced this pull request Mar 13, 2022
…oharbor#4719 (goharbor#15211)

Signed-off-by: Vadim Bauer <vb@container-registry.com>

Co-authored-by: Vadim Bauer <vb@container-registry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent "broken pipe" issue from mysql.
4 participants