Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 1.5: Fix issue that harbor tile can not save customized settings #5233

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Cherry-pick to 1.5: Fix issue that harbor tile can not save customized settings #5233

merged 2 commits into from
Jul 2, 2018

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 2, 2018

Use skip_reload_env_pattern in harbor.cfg to ignore some env when reload_config = true

@stonezdj stonezdj requested a review from reasonerjt July 2, 2018 10:40
@coveralls
Copy link

coveralls commented Jul 2, 2018 •
edited

Pull Request Test Coverage Report for Build 7511

  • 15 of 23 (65.22%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 64.43%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adminserver/systemcfg/systemcfg.go 15 23 65.22%
Files with Coverage Reduction New Missed Lines %
src/common/scheduler/scheduler.go 1 81.29%
src/adminserver/systemcfg/systemcfg.go 2 60.12%
Totals Coverage Status
Change from base Build 7271: 0.05%
Covered Lines: 10794
Relevant Lines: 16753
💛 - Coveralls

reasonerjt
reasonerjt approved these changes Jul 2, 2018
View reviewed changes
Copy link

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reasonerjt reasonerjt merged commit 3b0c8c6 into goharbor:release-1.5.0 Jul 2, 2018
@reasonerjt reasonerjt changed the title Fix issue that harbor tile can not save customized settings Cherry-pick to 1.5: Fix issue that harbor tile can not save customized settings Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reasonerjt reasonerjt reasonerjt approved these changes

Assignees

@reasonerjt reasonerjt

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stonezdj @coveralls @reasonerjt @vmwclabot