Fix issue ldap_group_admin_dn doesn't take effect(master) #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonezdj
changed the title
Pull Request Test Coverage Report for Build 8191
💛 - Coveralls |
reasonerjt
requested changes
Aug 15, 2018
stonezdj
force-pushed
the
fix_ldap_group_admin_dn
branch
2 times, most recently
from
f9787e4
to
dc90548
Compare
…'t have the harbor admin role. The current solution only fix the /api/users/currentuser, but for /api/users/:id it can display the real information. see issue goharbor#5620 Signed-off-by: stonezdj <stonezdj@gmail.com>
stonezdj
force-pushed
the
fix_ldap_group_admin_dn
branch
from
dc90548
to
764c43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If current user is in the group defined ldap_group_admin_dn, it doesn't have the harbor admin role.
The current solution only fix the /api/users/currentuser, but for /api/users/:id it can display the real information. see issue #5620
Signed-off-by: stonezdj stonezdj@gmail.com