Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating copyright notices #5690

Merged
merged 1 commit into from Sep 20, 2018
Merged

Updating copyright notices #5690

merged 1 commit into from Sep 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2018

Replacing copyright notices with "Copyright 2018 The Harbor Authors".

@ghost ghost requested a review from reasonerjt August 22, 2018 01:30
@coveralls
Copy link

coveralls commented Aug 22, 2018

Pull Request Test Coverage Report for Build 8708

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 64.347%

Files with Coverage Reduction New Missed Lines %
src/common/scheduler/scheduler.go 1 81.87%
Totals Coverage Status
Change from base Build 8697: 0.01%
Covered Lines: 12410
Relevant Lines: 19286

💛 - Coveralls

@ghost ghost force-pushed the clouderati-copyright-update branch from d30d4d3 to 2e611d9 Compare August 22, 2018 17:40
@ghost ghost mentioned this pull request Aug 23, 2018
@ghost
Copy link
Author

ghost commented Aug 23, 2018

@reasonerjt ptal

@reasonerjt
Copy link
Contributor

@clouderati sorry for the delay, could you please rebase?

@reasonerjt reasonerjt self-assigned this Sep 5, 2018
@ghost
Copy link
Author

ghost commented Sep 18, 2018

Need to tweak this a bit. @dankohn recommended that we use "Copyright 2018 Project Harbor Authors" in goharbor/website#5. Will rebase and update.

@dankohn
Copy link
Contributor

dankohn commented Sep 19, 2018

Also, my recommendation is "Copyright Project Harbor Authors" without the year.

@ghost
Copy link
Author

ghost commented Sep 19, 2018

Thanks for keeping me honest @dankohn! 😃

@ghost ghost force-pushed the clouderati-copyright-update branch from 2e611d9 to bd14c4d Compare September 19, 2018 16:58
@ghost
Copy link
Author

ghost commented Sep 19, 2018

@reasonerjt ptal

Signed-off-by: clouderati <35942204+clouderati@users.noreply.github.com>
@ghost ghost force-pushed the clouderati-copyright-update branch from bd14c4d to 587459d Compare September 19, 2018 16:59
@reasonerjt reasonerjt merged commit 6c84a3d into master Sep 20, 2018
@ghost ghost deleted the clouderati-copyright-update branch October 9, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants