Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication ng #7419

Merged
merged 37 commits into from Apr 17, 2019
Merged

Replication ng #7419

merged 37 commits into from Apr 17, 2019

Conversation

wy65701436
Copy link
Contributor

No description provided.

wy65701436 and others added 30 commits March 11, 2019 17:13
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: cd1989 <chende@caicloud.io>
Signed-off-by: wang yan <wangyan@vmware.com>
This commit is to build a regsitry bases on v2.7.1 code and introduces
an fix on issue goharbor#2819, this is a P0 bug on v2.7.1 which causes GCS doesn't
work well on v2.7.1

For more details, refer to distribution/distribution#2821

Signed-off-by: wang yan <wangyan@vmware.com>
Patch regsitry v2.7.1 with fix on distribution issue 2819
change the login module to fix the issue that the nav is being in page when we login harbor again

Signed-off-by: Yogi_Wang <yawang@vmware.com>
This commit adjust the code and fix some bugs to make onboard process
work.
Only thing missed is that the UI will need to initiate the redirection,
because the request of onboarding a user was sent via ajax call and didn't
handle the 302.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
As CLI does not support oauth flow, we'll use secret for help OIDC user
to authenticate via CLI.
Add column to store secret and token, and add code to support
verify/refresh token associates with secret.  Such that when the user is
removed from OIDC provider the secret will no longer work.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
For more context see PR goharbor#7335

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
user could copy the CLI secret when login through oidc, and using this cli secret as password when using docker/helm cli to access Harbor.

Signed-off-by: Yogi_Wang <yawang@vmware.com>
… user, push image to 1st project, and retag this image to 2nd project. (goharbor#7300)

Signed-off-by: danfengliu <danfengl@vmware.com>
…ents, and it has cause test case failure one time, so I modify all keywords in ToolKit.robot. (goharbor#7340)

Signed-off-by: danfengliu <danfengl@vmware.com>
Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Add Cli secret in Harbor user profile
adding token review endpoint to the configuration page allows users to edit token review endpoint when logging in through http auth.

Signed-off-by: Yogi_Wang <yawang@vmware.com>
…ew one. (goharbor#7355)

Signed-off-by: danfengliu <danfengl@vmware.com>
Add Token Review Endpoint in configuration page
This commit tweaks the attribute for auth proxy mode and OIDC auth mode.
To change it from "Skip verify cert" to "verify cert" so they are more
consistent with other modes.
Additionally it removes a workaround in `SearchUser` in auth proxy
authenticator.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Add space before right braket

Signed-off-by: Qian Deng <dengq@vmware.com>
Signed-off-by: Yogi_Wang <yawang@vmware.com>
rendering 443 when https enabled
rendering 4443 when notary enabled

Signed-off-by: Qian Deng <dengq@vmware.com>
…t_bug

Fix bug when rendering port in proxy
Add compatibility config in registry.yml

Signed-off-by: Qian Deng <dengq@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: FangyuanCheng <fangyuanc@vmware.com>
pureshine and others added 7 commits April 17, 2019 10:23
Fix cron input box and select box not in one line
Recovery a test case about 'should filter data by keyword' in the test file named repository-gridview.component.spec.ts
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
@coveralls
Copy link

coveralls commented Apr 17, 2019

Pull Request Test Coverage Report for Build 12187

  • 336 of 1065 (31.55%) changed or added relevant lines in 39 files are covered.
  • 51 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.8%) to 64.797%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/controllers/base.go 0 1 0.0%
src/common/http/error.go 4 6 66.67%
src/common/utils/oidc/testutils.go 8 11 72.73%
src/core/api/chart_repository.go 0 3 0.0%
src/core/auth/authproxy/auth.go 0 3 0.0%
src/core/api/base.go 0 4 0.0%
src/core/api/internal.go 0 7 0.0%
src/core/api/statistic.go 1 8 12.5%
src/core/api/email.go 5 13 38.46%
src/core/api/log.go 3 11 27.27%
Files with Coverage Reduction New Missed Lines %
src/common/utils/oidc/helper.go 1 49.18%
src/core/api/admin_job.go 1 8.15%
src/core/api/scan_job.go 1 0.0%
src/common/api/base.go 1 70.71%
src/core/api/email.go 2 80.0%
src/core/api/base.go 2 44.19%
src/core/controllers/oidc.go 2 0.0%
src/core/api/config.go 3 62.0%
src/core/api/statistic.go 3 42.68%
src/core/api/search.go 3 74.26%
Totals Coverage Status
Change from base Build 12173: -0.8%
Covered Lines: 15298
Relevant Lines: 23609

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants