Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #7829 #8094

Closed
wants to merge 1 commit into from
Closed

fix bug #7829 #8094

wants to merge 1 commit into from

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 21, 2019

fix bug for #7829

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13202

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 64.644%

Totals Coverage Status
Change from base Build 13200: 0.008%
Covered Lines: 16256
Relevant Lines: 25147

💛 - Coveralls

@jwangyangls
Copy link
Contributor

You will run git commit --amend --signoff before running git push

@jwangyangls
Copy link
Contributor

You should not develop codes in branch master,and you should checkout new branch

@@ -48,6 +48,7 @@ <h3 class="modal-title">{{headerTitle | translate}}</h3>
<div class="form-select">
<div class="select endpointSelect pull-left">
<select id="src_registry_id" (change)="sourceChange($event)" formControlName="src_registry" [compareWith]="equals">
<option style="display: none"></option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styles should be written in SCSS files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants