Retention: Implement Filter: Keep Latest K #8255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Lowe <public@nlowe.me>
nlowe
added
the
area/tag-retention
Pull Request Test Coverage Report for Build 13562
💛 - Coveralls |
steven-zou
requested changes
Jul 10, 2019
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestEvaluator_New(t *testing.T) { |
There was a problem hiding this comment.
Can we use the github.com/stretchr/testify testing framework to drive the test cases as I did in the or/processor_test.go?
| i = len(artifacts) | ||
| } | ||
|
|
||
| return artifacts[:i], nil |
There was a problem hiding this comment.
The input list does not guarantee the order. I think you need to do sort first and then return the k ones.
…r/testify/suite Signed-off-by: Nathan Lowe <public@nlowe.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports my WIP implementation to match the updated proposal.
Fixes #6660
Signed-off-by: Nathan Lowe public@nlowe.me