Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize cicd #8652

Closed
wants to merge 1 commit into from
Closed

Optimize cicd #8652

wants to merge 1 commit into from

Conversation

bitsf
Copy link
Contributor

@bitsf bitsf commented Aug 13, 2019

optimized CICD build process, use precompiled base image, move some static files from google storage to own server, fix cert creation and so on

@reasonerjt
Copy link
Contributor

@bitsf
The pre-compiled image may not have latest security fixes. The photon:2.0 base image on docker hub is maintained by a team continuously.
May I suggest that we revisit the process after branching 1.9 and figure out what can be improved?

@reasonerjt
Copy link
Contributor

@bitsf
Let me mark this PR as change requested to block accidental merge for now.

reasonerjt
reasonerjt requested changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily block the PR as we need more discussion.

@bitsf bitsf force-pushed the optimize_cicd branch 4 times, most recently from 47ccf5f to 11df249 Compare August 16, 2019 07:59
@coveralls
Copy link

coveralls commented Aug 16, 2019 •
edited

Pull Request Test Coverage Report for Build 15006

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.201%
Totals Coverage Status
Change from base Build 15005: 0.0%
Covered Lines: 22025
Relevant Lines: 33270
💛 - Coveralls

@bitsf bitsf force-pushed the optimize_cicd branch 12 times, most recently from fe1daba to 7a40919 Compare August 23, 2019 08:42
@bitsf
optimized cicd
9f3e2e9 
Change-Id: I1f40391b790a329c470d8de39278f834c132fc95
Signed-off-by: Ziming Zhang <zziming@vmware.com>
@stale
Copy link

stale bot commented Nov 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Nov 25, 2019
@stale stale bot closed this Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reasonerjt reasonerjt reasonerjt requested changes

@ninjadq ninjadq Awaiting requested review from ninjadq

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees

@wy65701436 wy65701436

Labels
area/ci enhancement Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bitsf @reasonerjt @coveralls @wy65701436 @steven-zou