Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scan by info in the scan report summary #9811

Merged
merged 1 commit into from Nov 9, 2019
Merged

add scan by info in the scan report summary #9811

merged 1 commit into from Nov 9, 2019

Conversation

steven-zou
Copy link
Contributor

@steven-zou
add scan by info in the scan report summary
7bdf249 
- fix goharbor#9795

Signed-off-by: Steven Zou <szou@vmware.com>
wy65701436
wy65701436 approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16693

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 65.967%
Files with Coverage Reduction New Missed Lines %
src/core/api/repository.go 3 48.94%
Totals Coverage Status
Change from base Build 16688: 0.003%
Covered Lines: 24437
Relevant Lines: 37044
💛 - Coveralls

@steven-zou steven-zou merged commit 5cebfd1 into goharbor:master Nov 9, 2019
@steven-zou steven-zou deleted the fix/issue_#9795_add_scan_by branch November 14, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@ywk253100 ywk253100 ywk253100 approved these changes

Assignees

@wy65701436 wy65701436

@ywk253100 ywk253100

Labels
area/interrogation-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Scan By: data field in the scan report summary
4 participants
@steven-zou @coveralls @wy65701436 @ywk253100