Harbor config system project quota #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Berndtsson <david.berndtsson@gmail.com>
Signed-off-by: David Berndtsson <david.berndtsson@gmail.com>
chhabriv
reviewed
Aug 25, 2023
| @@ -78,12 +83,17 @@ func resourceConfigSystemRead(d *schema.ResourceData, m interface{}) error { | |||
| if err != nil { | |||
| return fmt.Errorf("Error getting system configuration %s", err) | |||
| } | |||
| storage := jsonData.StoragePerProject.Value | |||
There was a problem hiding this comment.
We should accept the user input for storage quota in GB and then only convert it to bytes while making the API call?
There was a problem hiding this comment.
As far as I’m aware the api accept bytes. Did the converter to GB since we use it in other places as well which is an argument to DRY this part as well.
Signed-off-by: David Berndtsson <david.berndtsson@gmail.com>
Signed-off-by: Florian Blampey <flbla@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement the option to set default storage quotas for the projects.
This fixes #359