Update document for internal tls #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninjadq
force-pushed
the
add_san_to_cert_as_per_go_upgrade
branch
2 times, most recently
from
0f27b30
to
38c0210
Compare
a-mccarthy
requested changes
Feb 2, 2021
There was a problem hiding this comment.
Hi @ninjadq thanks for submitting. I added some wording suggestions, please let me know if you have any questions :)
As per issue goharbor/harbor#13745 Signed-off-by: DQ <dengq@vmware.com>
ninjadq
force-pushed
the
add_san_to_cert_as_per_go_upgrade
branch
from
38c0210
to
460b506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue goharbor/harbor#13745
Signed-off-by: DQ dengq@vmware.com