-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GC enhancement document #490
Add GC enhancement document #490
Conversation
@@ -37,7 +38,8 @@ You are able to schedule garbage colleciton on your Harbor interface from the ** | |||
* **Weekly**: Run garbage collection at midnight every Saturday. | |||
* **Custom**: Run garbage collection according to a `cron` job. | |||
|
|||
1. To **Allow garbage collection on untagged artifacts**, select the option. If you have this option turned on, the next time Garbage collect runs on your Harbor instance, Harbor will delete untagged artifacts and then perform garbage collection on them. | |||
1. To **Workers**, select the option. Set the number of workers that can execute GC tasks in parallel, the default value is 1. | |||
1. To **Allow garbage collection on untagged artifacts**, select the option. If you have this option turned on, the next time Garbage collect runs on your Harbor instance, Harbor will delete untagged artifacts and then perform garbage collection on them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also specify here what I tagged artifacts are. Specifically regarding latest tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes have been made to Allow garbage collection on untagged artifacts
. Allow garbage collection on untagged artifacts
will not affect tagged artifacts or the latest tag. These artifacts will not be GC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question was to improve the documentation in general. Because it is not clear to the user what untagged artifacts, means. goharbor/harbor#16326
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only add GC worker related descriptions, can you open a new issue or PR to track it down for other issues?
3f9ed75
to
d272162
Compare
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
d272162
to
5bfe1c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR only add GC worker related descriptions, can you open a new issue or PR to track it down for other issues?
No description provided.