Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GC enhancement document #490

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

YangJiao0817
Copy link
Member

No description provided.

Vad1mo
Vad1mo previously requested changes Aug 25, 2023
@@ -37,7 +38,8 @@ You are able to schedule garbage colleciton on your Harbor interface from the **
* **Weekly**: Run garbage collection at midnight every Saturday.
* **Custom**: Run garbage collection according to a `cron` job.

1. To **Allow garbage collection on untagged artifacts**, select the option. If you have this option turned on, the next time Garbage collect runs on your Harbor instance, Harbor will delete untagged artifacts and then perform garbage collection on them.
1. To **Workers**, select the option. Set the number of workers that can execute GC tasks in parallel, the default value is 1.
1. To **Allow garbage collection on untagged artifacts**, select the option. If you have this option turned on, the next time Garbage collect runs on your Harbor instance, Harbor will delete untagged artifacts and then perform garbage collection on them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also specify here what I tagged artifacts are. Specifically regarding latest tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes have been made to Allow garbage collection on untagged artifacts. Allow garbage collection on untagged artifacts will not affect tagged artifacts or the latest tag. These artifacts will not be GC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question was to improve the documentation in general. Because it is not clear to the user what untagged artifacts, means. goharbor/harbor#16326

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only add GC worker related descriptions, can you open a new issue or PR to track it down for other issues?

@YangJiao0817 YangJiao0817 force-pushed the add-gc-enhancement-doc branch 2 times, most recently from 3f9ed75 to d272162 Compare August 28, 2023 09:29
Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 dismissed Vad1mo’s stale review August 30, 2023 04:53

This PR only add GC worker related descriptions, can you open a new issue or PR to track it down for other issues?

@YangJiao0817 YangJiao0817 merged commit 78fd88c into goharbor:main Aug 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants